Date: Sun, 17 Aug 2003 13:07:23 +0200 From: "Simon L. Nielsen" <simon@FreeBSD.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: freebsd-doc@FreeBSD.org Subject: Re: Review of porters-handbook changes Message-ID: <20030817110722.GA391@FreeBSD.org> In-Reply-To: <1061069299.54862.34.camel@shumai.marcuscom.com> References: <1061069299.54862.34.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/9DWx/yDrRhgMJTb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2003.08.16 17:28:19 -0400, Joe Marcus Clarke wrote:
> Can someone review the attached diff to the porter's handbook? It was
> submitted by Sergey Matveychuk <sem@ciam.ru> for some of the recent
> ports infrastructure changes. It is technically accurate, and I fixed a
> few grammar and spelling nits, but I would like a doc committers take on
> it before committing. Also, if one of you would rather commit, that's
> fine. Thanks!
There are some places where 8 spaces have been used instead of a tab
(can be fixed by marking the regions and using 'meta-x tabify' in
emacs'). There are also some end of line white-spaces which should be
removed.
> --- doc/en_US.ISO8859-1/books/porters-handbook/book.sgml 10 Aug 2003 20:3=
4:31 -0000 1.319
> +++ doc/en_US.ISO8859-1/books/porters-handbook/book.sgml 16 Aug 2003 21:2=
4:46 -0000
> @@ -3216,11 +3227,23 @@
> =20
> <entry>Says that the port uses Perl 5 to build and run.</entry>
> </row>
> - =20
> +
> <row>
> - <entry><makevar>PERL</makevar></entry>
> + <entry><makevar>PERL_CONFIGURE</makevar></entry>
> +
> + <entry>Configure using Perl's MakeMaker. It implies USE_PERL5.</=
entry>
^^^^^^^^^
Missing makevar tag.
> @@ -4316,6 +4083,19 @@
> </note>
> </sect1>
> =20
> + <sect1 id=3D"pkg-deinstall">
> + <title><filename>pkg-deinstall</filename></title>
> +
> + <para>This script executes when a package is removed.</para>
> +
> + <para>
> + Like the <filename>pkg-install</filename> script it will be run twice.
> + The first time as <literal>${SH} pkg-install ${PKGNAME}
> + DEINSTALL</literal> and the second time as
> + <literal>${SH} pkg-install ${PKGNAME} POST-DEINSTALL</l=
iteral>.
> + </para>
Perhaps a reference to pkg_delete(1) ?
Otherwise it looks OK to me, but I have only checked the markup, not the
language.
--=20
Simon L. Nielsen
FreeBSD Documentation Team
--/9DWx/yDrRhgMJTb
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)
iD8DBQE/P2Hqh9pcDSc1mlERAkMvAKDMSmoC0/LvV1cd3KNmeoyvomgTBQCfaDUT
X1dQ6lXGAZVn5JbQdeI5rlU=
=aKJJ
-----END PGP SIGNATURE-----
--/9DWx/yDrRhgMJTb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030817110722.GA391>