Date: Sun, 04 Jan 2004 22:43:02 -0500 From: "Bryce Nesbitt (mailing list account)" <bryce1@obviously.com> To: =?ISO-8859-1?Q?Ville_Skytt=E4?= <scop@FreeBSD.org>, freebsd-cvsweb@freebsd.org Subject: Re: Patch to cvsweb? Message-ID: <3FF8DD46.5090501@obviously.com> In-Reply-To: <1073247519.9121.183.camel@bobcat.mine.nu> References: <3FB23C1F.6040502@obviously.com> <1068661352.4763.72.camel@bobcat.mine.nu> <3FB28082.6070707@obviously.com> <1068671035.4763.136.camel@bobcat.mine.nu> <3FBCEA3F.4050106@obviously.com> <1069350659.2439.274.camel@bobcat.mine.nu> <3FD3547A.5010400@obviously.com> <1070867585.11239.52.camel@bobcat.mine.nu> <3FDF6F74.4070307@obviously.com> <1071618494.6993.81.camel@bobcat.mine.nu> <3FEB7626.2030606@obviously.com> <1072528568.7528.127.camel@bobcat.mine.nu> <3FEF5E93.8020600@obviously.com> <1073247519.9121.183.camel@bobcat.mine.nu>
next in thread | previous in thread | raw e-mail | index | archive | help
I agree that using CVS's "b" (binary) flag is a good hint.
But why hard code the response? For each combination of binary flag and
mime type, I might want select allowable diff and download types
independently:
Diff as:
text
colored
side-by-side
shape_diff.exe (external)
exell_diff.exe (external)
Download as:
Native mime type (e.g. "application/msword")
As text
The default could be to enable everything except the
external diff utilities.
-Bryce
Ville Skyttä wrote:
>All true. Currently I'm thinking about using CVS's keyword expansion
>mode to "detect" whether a file is a text file in the first place (if
>possible everywhere, haven't checked yet). If a file is checked in
>using the "b" (binary) mode, we treat it as binary and will not offer
>HTMLized view of it, or a regular diff. On the other hand, if it does
>not have the "b" flag set, we'll show the "(download as text)" link if
>the resolved MIME type is not "text/*", ditto show many diff
>links/options including a "regular diff" link if the file has dedicated
>diff tool(s) but is a text file etc etc, lots of work to do.
>
>>Bryce wrote:
>>The issue is complex. For an XML file I might want the choice to diff
>>it as a text file, OR
>>use a generic XML diff utility, OR using a specilized utility that
>>understands the content.
>>As a system administrator I might want to prohibit diffing some files
>>as text, because I know
>>the results will be nonsense.
>>
>>
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FF8DD46.5090501>