Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 May 2005 09:08:12 -0400
From:      "Adam Kropelin" <akropel1@rochester.rr.com>
To:        "Thierry Thomas" <thierry@freebsd.org>, "Lonnie Mendez" <lmendez19@austin.rr.com>
Cc:        freebsd-usb@freebsd.org
Subject:   Re: kern/80383: [PATCH] Add quirk for uhid to ignore certain usbdevices (blacklist)
Message-ID:  <004c01c54e4e$d45baa80$03c8a8c0@kroptech.com>
References:  <20050427055531.07B7D60FB@gnome.dnsalias.net> <20050430160650.GC95709@graf.pompo.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Thierry Thomas wrote:
>> Le Mer 27 avr 05 à  7:55:31 +0200, Lonnie Mendez
>> <lmendez19@austin.rr.com> écrivait :
>>>
>>>> Number:         80383
>>>> Category:       kern
>>>> Synopsis:       [PATCH] Add quirk for uhid to ignore certain usb
>>>> devices (blacklist)
>>
>>>> Description:
>>>
>>> This patch allows uhid to leave alone devices that identify
>>> themselves as hid based, but are indeed
>>> used via another interface.  This is very simliar in concept to the
>>> hid blacklist table found in hid-core.c in the linux kernel.
>>
>> Fine! I also need this to use the new MGE UPS devices (with nut,
>> libusb and the newhidups driver). I have applied the submitted patch
>> on a
>> 5.4-STABLE, and it's OK.
>>
>> To add the MGE UPS devices, I need the attached patches.

Just to nitpick a little...

> +product MGE UPS1  0x0001 MGEUPS newhidups 1
> +product MGE UPS2  0xffff MGEUPS newhidups 2

I'm not sure it's appropriate in this context to refer to a userspace 
program like "newhidups". I think this field is really meant to be a textual 
name for the product being identified. Based on the other entries in the 
file, something like a model name or generc description may be more 
appropriate.

--Adam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?004c01c54e4e$d45baa80$03c8a8c0>