Date: Sun, 30 Sep 2007 13:33:12 +1300 From: Sam Banks <w0lfie@clear.net.nz> To: freebsd-current@freebsd.org Subject: uipc_sockbuf sysctl Message-ID: <46feeec8.106.9f9.24060@clear.net.nz>
index | next in thread | raw e-mail
[-- Attachment #1 --]
Hey all,
I have started looking into cleaning up sysctl's with empty
descriptions and have come across kern.dummy.
Looking into sys/kern/uipc_sockbuf.c, kern.dummy does
absolutely nothing other than offer the ability to change
it. The variable that the sysctl call populates (dummy) is
not used directly in sys/kern/uipc_sockbuf.c or, as far as I
can see, anywhere in the sys/ code.
Is there a reason I'm missing why this seemingly uneeded
sysctl call is in the code or can it be removed with the
attached patch?
Cheers,
Sam.
[-- Attachment #2 --]
Index: sys/kern/uipc_sockbuf.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/uipc_sockbuf.c,v
retrieving revision 1.171
diff -u -r1.171 uipc_sockbuf.c
--- sys/kern/uipc_sockbuf.c 31 May 2007 11:51:22 -0000 1.171
+++ sys/kern/uipc_sockbuf.c 30 Sep 2007 00:18:06 -0000
@@ -1029,8 +1029,6 @@
}
/* This takes the place of kern.maxsockbuf, which moved to kern.ipc. */
-static int dummy;
-SYSCTL_INT(_kern, KERN_DUMMY, dummy, CTLFLAG_RW, &dummy, 0, "");
SYSCTL_OID(_kern_ipc, KIPC_MAXSOCKBUF, maxsockbuf, CTLTYPE_ULONG|CTLFLAG_RW,
&sb_max, 0, sysctl_handle_sb_max, "LU", "Maximum socket buffer size");
SYSCTL_ULONG(_kern_ipc, KIPC_SOCKBUF_WASTE, sockbuf_waste_factor, CTLFLAG_RW,
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46feeec8.106.9f9.24060>