Date: Sat, 14 Nov 2009 21:04:41 -0800 From: Xin LI <delphij@delphij.net> To: Jilles Tjoelker <jilles@stack.nl> Cc: Anonymous <swell.k@gmail.com>, freebsd-current@FreeBSD.ORG, d@delphij.net, matthew green <mrg@eterna.com.au> Subject: Re: svn commit: r199066 - head/usr.bin/gzip Message-ID: <4AFF8BE9.9000003@delphij.net> In-Reply-To: <20091114130524.GA35115@stack.nl> References: <200911090237.nA92b2m7005471__19254.880565177$1257734275$gmane$org@svn.freebsd.org> <867htvhygy.fsf@gmail.com> <4AFDDEA1.70900@delphij.net> <4AFDE27F.1070406@delphij.net> <4AFDEB70.5080807@delphij.net> <20091114130524.GA35115@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jilles Tjoelker wrote: > On Fri, Nov 13, 2009 at 03:27:44PM -0800, Xin LI wrote: >> The previous fix has introduced an issue that revealed another bug as >> well (gzip -d -c can't decompress large-ish input stream, i.e. something >> like bzip2 -c ObsoleteFiles.inc | gunzip -d -c). The proposed patch: > >> * Set end_of_file flag if we hit a short read. This usually saves one >> read after the actual end of file. > > A short read does not necessarily mean EOF on a pipe or other > non-regular file. Yes you're right, what we really need is to distinguish between an non-existent end of file and a real short read. I'll see if I would have some other alternatives. Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAkr/i+kACgkQi+vbBBjt66BqvQCgokChJF0RLKP/v1R7dNaWbtcP wAMAn29dHIxhGRwqI0IEjZhIIwxbT63X =g18V -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AFF8BE9.9000003>