Date: Sat, 26 Oct 2013 20:22:27 -0400 From: Eitan Adler <lists@eitanadler.com> To: Sean Bruno <sbruno@freebsd.org> Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: [PATCH] contrib/groff Queisce -Wdangling else Message-ID: <CAF6rxg=GRnNHf-APiumRRdH5smbNk=C%2BvrxyFSdQEPnfw5fKzg@mail.gmail.com> In-Reply-To: <1382799852.32760.2.camel@localhost> References: <1382799852.32760.2.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno <sean_bruno@yahoo.com> wrote: > This adds proper braces to clear Clang warnings about dangling else > statements in groff. There is no(intended) functional change. For contributed code why not just disable warnings? Fixing code is good but doing so in our repository instead of upstream doesn't help as much. -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=GRnNHf-APiumRRdH5smbNk=C%2BvrxyFSdQEPnfw5fKzg>