Date: Sun, 16 Nov 2014 12:34:48 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-wireless@FreeBSD.org Subject: [Bug 193588] [new port] net/malo-firmware-1.4: Staged malo(4) firmware module Message-ID: <bug-193588-21060-f6b6Hh9RgR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193588-21060@https.bugs.freebsd.org/bugzilla/> References: <bug-193588-21060@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193588 Bartek Rutkowski <robak@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch Ready |In Discussion --- Comment #22 from Bartek Rutkowski <robak@freebsd.org> --- John, I've few doubts about the package, namely the issues listed by portlint: WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: Consider defining LICENSE. WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them. WARN: Makefile: "NO_PACKAGE" found. do not forget to update ports/LEGAL. and the fact that the port is called 'malo-firmware-1.4' however, the port version seems to be extracted from firmware version, that comes from distfiles and currently is '3.0.0.39', so the package name will be extremely confusing, like 'malo-firmware-1.4-3.0.0.39'. Beside that, what's the '1.4', if the port version is '3.0.0.39'? Mind looking into the Makefile a bit more carefully and help us solve the puzzle? -- You are receiving this mail because: You are on the CC list for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193588-21060-f6b6Hh9RgR>