Date: Thu, 17 Mar 2016 23:33:08 +0000 (UTC) From: Jason Helfman <jgh@FreeBSD.org> To: doc-committers@freebsd.org, svn-doc-user@freebsd.org Subject: svn commit: r48428 - user/jgh/committers-guide Message-ID: <201603172333.u2HNX8w8006480@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jgh Date: Thu Mar 17 23:33:08 2016 New Revision: 48428 URL: https://svnweb.freebsd.org/changeset/doc/48428 Log: - wip Modified: user/jgh/committers-guide/article.xml Modified: user/jgh/committers-guide/article.xml ============================================================================== --- user/jgh/committers-guide/article.xml Thu Mar 17 18:45:01 2016 (r48427) +++ user/jgh/committers-guide/article.xml Thu Mar 17 23:33:08 2016 (r48428) @@ -3151,7 +3151,7 @@ Subscribers:<co xml:id="phabricator-subs <step> <para>Go to <link xlink:href="https://reviews.freebsd.org/differential/">; - https://reviews.freebsd.org/differential/</link></para>; + https://reviews.freebsd.org/differential/</link></para>; </step> <step> @@ -3197,7 +3197,7 @@ Subscribers:<co xml:id="phabricator-subs <step> <para>Go to <link xlink:href="https://reviews.freebsd.org/differential/">; - https://reviews.freebsd.org/differential/</link></para>; + https://reviews.freebsd.org/differential/</link></para>; </step> <step> @@ -3226,22 +3226,28 @@ Subscribers:<co xml:id="phabricator-subs <title>Address Revision Feedback</title> <para>If a reviewer does not accept the change and asks - for a modification to the, edit the files in the local - client accordingly.</para> + for a modification to the, edit the files in the local + client accordingly.</para> <para>While doing so, fill in replies to any line-specific - comments that a reviewer may have left. Saving replies does - not cause them to be sent out. You must click the - <emphasis>Submit</emphasis> button for these to be sent - out.</para> - - <para>After addressing all comments, upload the patch. - path should included all paths that are part of the review, - even if their contents haven't changed as part of this - update.</para> - + comments that a reviewer may have left. Saving replies does + not cause them to be sent out. You must click the + <emphasis>Submit</emphasis> button for these to be sent + out.</para> + + <para>After addressing all comments, upload the patch.</para> + + <example> + <screen>&prompt.root; <userinput>arc diff --update D<replaceable>XXX path</replaceable></userinput></screen> + </example> + + <para>The <emphasis>path</emphasis> should included all paths + that are part of the review, even if their contents haven't + changed as part of this update.</para> </sect2> - </sect1> + + </sect2> +</sect1> <sect1 xml:id="people"> <title>Who's Who</title>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603172333.u2HNX8w8006480>