Date: Sun, 9 Oct 2016 03:20:58 +0000 (UTC) From: Allan Jude <allanjude@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r306896 - head/sbin/ifconfig Message-ID: <201610090320.u993KwVD008493@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: allanjude Date: Sun Oct 9 03:20:58 2016 New Revision: 306896 URL: https://svnweb.freebsd.org/changeset/base/306896 Log: Fix spurious white space introduced in r301059 r301059 accidently introduced a subtle change for point to point interfaces where an extra space is inserted before the netmask. This can cause issues for scripts that parse ifconfig output. Submitted by: Kevin Bowling <kevin.bowling@kev009.com> Reviewed by: hiren MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D8199 Modified: head/sbin/ifconfig/af_inet.c head/sbin/ifconfig/af_inet6.c Modified: head/sbin/ifconfig/af_inet.c ============================================================================== --- head/sbin/ifconfig/af_inet.c Sun Oct 9 01:58:29 2016 (r306895) +++ head/sbin/ifconfig/af_inet.c Sun Oct 9 03:20:58 2016 (r306896) @@ -88,7 +88,7 @@ in_status(int s __unused, const struct i sin = (struct sockaddr_in *)ifa->ifa_dstaddr; if (sin == NULL) sin = &null_sin; - printf(" --> %s ", inet_ntoa(sin->sin_addr)); + printf(" --> %s", inet_ntoa(sin->sin_addr)); } sin = (struct sockaddr_in *)ifa->ifa_netmask; Modified: head/sbin/ifconfig/af_inet6.c ============================================================================== --- head/sbin/ifconfig/af_inet6.c Sun Oct 9 01:58:29 2016 (r306895) +++ head/sbin/ifconfig/af_inet6.c Sun Oct 9 03:20:58 2016 (r306896) @@ -237,7 +237,7 @@ in6_status(int s __unused, const struct if (error != 0) inet_ntop(AF_INET6, &sin->sin6_addr, addr_buf, sizeof(addr_buf)); - printf(" --> %s ", addr_buf); + printf(" --> %s", addr_buf); } }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201610090320.u993KwVD008493>