Date: Sat, 2 Jun 2018 21:07:50 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: freebsd-current@freebsd.org Cc: mmacy@freebsd.org Subject: Weird conditional logic in lib/libpmc/Makefile Message-ID: <20180603010750.zo4qngsqouiajcpo@mutt-hbsd>
index | next in thread | raw e-mail
[-- Attachment #1 --]
Hey all,
Below is some logic pasted from lib/libpmc/Makefile:
.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386"
.if ${MACHINE_ARCH} == "aarch64"
EVENT_ARCH="arm64"
.elif ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386"
EVENT_ARCH="x86"
.elif ${MACHINE_ARCH} == "powerpc"
EVENT_ARCH="powerpc"
.endif
JEVENTS= ${BTOOLSPATH:U.}/pmu-events/jevents
# This file is built in a subdirectory so never try to rebuild
# it here due to missing meta file.
${JEVENTS}: .NOMETA
libpmc_events.c: ${JEVENTS}
${JEVENTS} ${EVENT_ARCH} ${.CURDIR}/pmu-events/arch libpmc_events.c
SRCS+= libpmc_events.c
.endif
Why perform the conditionals for aarch64 and powerpc when it can't be
those? "Am I missing something?
I'm looping in Matt Macy, who was the last person to touch the file.
Thanks,
--
Shawn Webb
Cofounder and Security Engineer
HardenedBSD
Tor-ified Signal: +1 443-546-8752
Tor+XMPP+OTR: lattera@is.a.hacker.sx
GPG Key ID: 0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlsTP2IACgkQaoRlj1JF
bu45mg/8CCfv2XCKlRlzPtqPNO+9XD4vMGeicyTV0OvIOTOp5HXiiXe72PDyBP+P
D9rvgnpfK5e400k4H/ELnByaqdgyWbOiLSySBXAY8Z3aZlI2ftP0+X89DY4F5FJs
yrUaKavTQGkOqXL5R+acga8CkqqvXfgz8IHScewDnjTJoa5ZaJu0LoJpf3ABQBfO
941IZ/cNsCilwbEc08cwxu01JJv0/8PASZu83ABbBKdmUBmv/KLnmkPAoLrpkri3
mHEHhGQ8N3butgUWMFXZV9sYCVxmVnMyze2s2ccD16goQDuNW3xZCimnf7wi25bS
1sl7DlTtTaWsuhN5S527wdIWeqQKirLZ5HCa2RpwuS/lVdjWaqa4pfct+S8nWRq3
5aIj31XmSCcvD3DnBLBkZaftFT6M+N3WsC7llKnVREly0MzFZkv30mVJB0rQShfn
11MThyfWWYEJnTGmRI9dFA+G6/wpvpPefkd9Yle9FbSHoNS0ySt916HwJswzoLfJ
QICFJSPMNST4CMvaDEWhVZONot2FbAzNTM1nnlvY81NBFK6fobR1Jps7LTCjqiqT
Om8NKtgh4/Ob4o8hCnfWbvMICL4Zt5UPLBkoaxWUDfYAWUXxPzZE1GzWVQd3v28C
gpKNNYQOza0vVi7YwWBfd8rpU0wAWzBa0xNRVFIeIv7zfHlrFrw=
=KB6N
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180603010750.zo4qngsqouiajcpo>