Date: Sun, 24 May 2020 04:26:43 +0200 From: Damjan Jovanovic <damjan.jov@gmail.com> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: freebsd-emulation@freebsd.org Subject: Re: Wine 5.9 bugfix Message-ID: <CAJm2B-mg8BdGKCXJEgYT79QwNVGrT1COfOpRwHDCDkub1eoseQ@mail.gmail.com> In-Reply-To: <alpine.LSU.2.21.2005232130580.4832@anthias.pfeifer.com> References: <CAJm2B-m1JU%2B6J88=7r19cP9y=UXV%2BYmMQwoJgA_Ce1-bWPjiKA@mail.gmail.com> <alpine.LSU.2.21.2005232130580.4832@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 23, 2020 at 9:53 PM Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Sat, 23 May 2020, Damjan Jovanovic wrote: > > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > > FreeBSD should be fixed upstream now. > > Thank you for debugging and even fixing those, Damjan - and even doing > so upstream! > > > However I accidentally introduced another bug recently, where we don't > > check the return value from an mmap() call, resulting in assertion > failures > > and possibly memory corruption... I debugged it and a patch to fix it is > > available (https://source.winehq.org/patches/data/185684). Please build > > ports with that patch applied to 5.9. Sorry. > > I just started test builds of emulators/wine-devel with that patch. > > So far I have kept files/patch-tools-winegcc which reverts the upstream > change (1ccd638b1aa85fb3c43b49d69d279cd509ebdc21) that kicked of this > avalanche of events. I was thinking to keep that as part of our port > until the next snapshot (Wine 5.10) - do you have any strong feelings > or recommendations either way? > > While I don't completely understand the many changes there, I would advise against files/patch-tools-winegcc as Linux doesn't use it, and the only issue on FreeBSD was that rtld-elf problem which Wine worked around in 5.9. > Thanks, > Gerald > Damjan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJm2B-mg8BdGKCXJEgYT79QwNVGrT1COfOpRwHDCDkub1eoseQ>