Date: Tue, 4 Feb 2025 00:32:31 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: Any real usage of sppp(4) on architectures other than i386 or amd64 ? Message-ID: <57B63ECF-F2A2-43FB-8814-B2BDF7CEB9F4@FreeBSD.org> In-Reply-To: <Z4bJihbQUmD0cjpN@cell.glebi.us> References: <0DC91E3B-DDB4-43ED-866E-3DA02BBA1241@FreeBSD.org> <Z4bJihbQUmD0cjpN@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jan 15, 2025, at 4:31 AM, Gleb Smirnoff <glebius@freebsd.org> = wrote: >=20 > On Tue, Jan 14, 2025 at 07:25:26PM +0800, Zhenlei Huang wrote: > Z> I just fixed one long standing bug of sppp(4) [1]. During the = testing I found ng_sppp(4) depends on this module. Unfortunately sppp(4) = is only enabled on i386 and amd64 by default but ng_sppp(4) is enabled = on all architectures. So on architectures other than i386 and amd64 = `kldload ng_sppp` will never succeed. > Z>=20 > Z> I suppose sppp(4) is rarely used nowadays so I'm planing to = conditionally build ng_sppp(4) only on i386 and amd64. Is there still = real usage of sppp(4) on other architectures ? > Z>=20 > Z> 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D173002 >=20 > I would claim there is no usage of neither sppp(4) nor ng_sppp(4) on = any > architecture in a very long term. Last time I run this kind of = network framing > in 2004 and in that times the right way to do it was either pure = negraph(4) > graph based on ng_cisco(4) or ports/net/mpd + ng_ppp(4). >=20 > Don't waste your time on this code. This is a quick simple fix. Committed as = https://cgit.freebsd.org/src/commit/?h=3Dstable/13&id=3D29f77be0d844aa7e9b= 26fed8b550e12ad504b4d2 = <https://cgit.freebsd.org/src/commit/?h=3Dstable/13&id=3D29f77be0d844aa7e9= b26fed8b550e12ad504b4d2> . >=20 > --=20 > Gleb Smirnoff --Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Jan 15, 2025, at 4:31 AM, Gleb Smirnoff <<a = href=3D"mailto:glebius@freebsd.org" class=3D"">glebius@freebsd.org</a>>= wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = class=3D"">On Tue, Jan 14, 2025 at 07:25:26PM +0800, Zhenlei Huang = wrote:<br class=3D"">Z> I just fixed one long standing bug of sppp(4) = [1]. During the testing I found ng_sppp(4) depends on this module. = Unfortunately sppp(4) is only enabled on i386 and amd64 by default but = ng_sppp(4) is enabled on all architectures. So on architectures other = than i386 and amd64 `kldload ng_sppp` will never succeed.<br = class=3D"">Z> <br class=3D"">Z> I suppose sppp(4) is rarely used = nowadays so I'm planing to conditionally build ng_sppp(4) only on i386 = and amd64. Is there still real usage of sppp(4) on other architectures = ?<br class=3D"">Z> <br class=3D"">Z> 1. <a = href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D173002" = class=3D"">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D173002</a><= br class=3D""><br class=3D"">I would claim there is no usage of neither = sppp(4) nor ng_sppp(4) on any<br class=3D"">architecture in a very long = term. Last time I run this kind of network framing<br class=3D"">in = 2004 and in that times the right way to do it was either pure = negraph(4)<br class=3D"">graph based on ng_cisco(4) or ports/net/mpd + = ng_ppp(4).<br class=3D""><br class=3D"">Don't waste your time on this = code.<br class=3D""></div></div></blockquote><div><br = class=3D""></div><div>This is a quick simple fix.</div><div>Committed = as <a = href=3D"https://cgit.freebsd.org/src/commit/?h=3Dstable/13&id=3D29f77b= e0d844aa7e9b26fed8b550e12ad504b4d2" = class=3D"">https://cgit.freebsd.org/src/commit/?h=3Dstable/13&id=3D29f= 77be0d844aa7e9b26fed8b550e12ad504b4d2</a> .</div><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = class=3D""><br class=3D"">-- <br class=3D"">Gleb Smirnoff<br = class=3D""></div></div></blockquote></div><div class=3D""><div><br = class=3D""></div> </div> <br class=3D""></body></html>= --Apple-Mail=_DD3B302C-DB63-417E-A41A-163BB018914D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57B63ECF-F2A2-43FB-8814-B2BDF7CEB9F4>