Date: Fri, 14 Apr 2017 09:55:39 -0600 From: Alan Somers <asomers@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r316854 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <CAOtMX2iEZR0J=jmRWp5mkKuhO%2BAZfu_TESFMsTWOcjvUPCOBJg@mail.gmail.com> In-Reply-To: <201704141535.v3EFZ7BY096442@repo.freebsd.org> References: <201704141535.v3EFZ7BY096442@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Are you sure it's a good idea to MFC this change? Doing so will upset anybody currently setting that sysctl in /etc/sysctl.conf. On Fri, Apr 14, 2017 at 9:35 AM, Andriy Gapon <avg@freebsd.org> wrote: > Author: avg > Date: Fri Apr 14 15:35:07 2017 > New Revision: 316854 > URL: https://svnweb.freebsd.org/changeset/base/316854 > > Log: > rename vfs.zfs.debug_flags to vfs.zfs.debugflags > > While the former name is easier to read, the "_flags" suffix has a special > meaning for loader(8) and, thus, it was impossible to set the knob via > loader.conf(5). The loader interpreted the setting as flags that should > be passed to a kernel module named "vfs.zfs.debug". > > Discussed with: smh > MFC after: 2 weeks > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c Fri Apr 14 15:31:04 2017 (r316853) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c Fri Apr 14 15:35:07 2017 (r316854) > @@ -353,7 +353,7 @@ sysctl_vfs_zfs_debug_flags(SYSCTL_HANDLE > return (0); > } > > -SYSCTL_PROC(_vfs_zfs, OID_AUTO, debug_flags, > +SYSCTL_PROC(_vfs_zfs, OID_AUTO, debugflags, > CTLTYPE_UINT | CTLFLAG_MPSAFE | CTLFLAG_RWTUN, 0, sizeof(int), > sysctl_vfs_zfs_debug_flags, "IU", "Debug flags for ZFS testing."); > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2iEZR0J=jmRWp5mkKuhO%2BAZfu_TESFMsTWOcjvUPCOBJg>