Date: Mon, 31 Mar 2008 20:00:02 +0200 (CEST) From: Harald Schmalzbauer <harry@omnisec.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: misc/122300: SEPARATE_LIVEFS arch dependent set but unclear Message-ID: <200803311800.m2VI027F034877@titan.flintsbach.schmalzbauer.de> Resent-Message-ID: <200803311810.m2VIA1jO096682@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 122300
>Category: misc
>Synopsis: SEPARATE_LIVEFS arch dependent set but unclear
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: doc-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 31 18:10:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Harald Schmalzbauer
>Release: FreeBSD 7.0-STABLE i386
>Organization:
OmniSEC
>Environment:
System: FreeBSD titan.flintsbach.schmalzbauer.de 7.0-STABLE FreeBSD 7.0-STABLE #1: Thu Mar 27 09:36:49 CET 2008 root@titan.flintsbach.schmalzbauer.de:/usr/obj/usr/src/sys/TITAN i386
>Description:
In release/Makefile for all target architectures besides sparc64
SEPARATE_LIVEFS ist defined without true or false and evaluated by ifdef.
So at a fisrt look it seems SEPARATE_LIVEFS ist _not_ set, but a closer look
shows the opposite.
I don't know why LIVEFS is not on disc1 by default any more, but making that
more clear by setting SEPARATE_LIVEFS to true may help some peaople not too
familar with release process.
>How-To-Repeat:
Watch line 195 in src/release/Makefile an the corresponding evaluation
in line 267, 494 with 498, 970 and 1056
>Fix:
The following patch has no functional change but makes the setting more
obvious:
--- src/release/Makefile.orig 2008-03-31 19:49:09.000000000 +0200
+++ src/release/Makefile 2008-03-31 19:49:53.000000000 +0200
@@ -192,7 +192,7 @@
.undef MAKE_FLOPPIES
.if ${TARGET_ARCH} == "i386"
MAKE_FLOPPIES= true
-SEPARATE_LIVEFS=
+SEPARATE_LIVEFS= true
SPLIT_MFSROOT=
.if ${TARGET} == "pc98"
SMALLFLOPPYSIZE= 1200
@@ -218,7 +218,7 @@
MFSSIZE= 8192
MFSINODE= 8192
MFSLABEL= auto
-SEPARATE_LIVEFS=
+SEPARATE_LIVEFS= true
.elif ${TARGET_ARCH} == "amd64"
MAKE_FLOPPIES= true
FLOPPYSIZE= 1440
@@ -229,14 +229,14 @@
MFSSIZE= 4096
MFSINODE= 8192
MFSLABEL= auto
-SEPARATE_LIVEFS=
+SEPARATE_LIVEFS= true
SPLIT_MFSROOT=
.elif ${TARGET_ARCH} == "powerpc"
DISKLABEL= ""
MFSSIZE= 4096
MFSINODE= 8192
MFSLABEL= auto
-SEPARATE_LIVEFS=
+SEPARATE_LIVEFS= true
.endif
.if defined(NO_FLOPPIES)
.undef MAKE_FLOPPIES
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803311800.m2VI027F034877>