Date: Tue, 22 Jan 2002 23:31:11 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Will Andrews <will@csociety.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/mail/evolution pkg-plist ports/mail/evolution/files patch-ac patch-camel::providers::local::Makefile.in patch-camel::providers::nntp::Makefile.in patch-camel::providers::pop3::Makefile.in patch-camel::providers::sendmail::Makefile.in patch-camel::providers::smtp::Makefile.in patch-mail::importers::Makefile.in Message-ID: <3C4DDA1F.622EAD6F@FreeBSD.org> References: <200201222039.g0MKdcm91935@freefall.freebsd.org> <20020122154603.H18609@squall.waterspout.com> <3C4DD282.A1FA297C@FreeBSD.org> <20020122160948.I18609@squall.waterspout.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Will Andrews wrote:
>
> On Tue, Jan 22, 2002 at 10:58:42PM +0200, Maxim Sobolev wrote:
> > Names are auto-generated, so I don't really care.
>
> They might affect some things, like the cpio bug that someone
> reported to Murray last week. And they're unsightly... you
> should fix your script so it optimizes the name lengths.
Well, the idea behind those sometimes long names is that there is
always 1:1 mapping between the file in port and corresponding
patchfile, so that the history is automagically preserved (no need to
look at logs as with old patch-xy scheme) even if you will delete
patchfile at some point and put it back later. No form of
"optimization" could gurantee that, and just stripping several levels
of hierarchy is the worst optimization possible. If I ever go that way
I'd just replace those long strings with md5 hash of the path relative
to ${WRKSRC} - this at least would minimize likelyhood of collision.
> > Well, considering that those patches are to be submitted back to
> > developers this isn't a good idea either.
>
> They're the same thing. Just one gets the message across a lot
> more concisely.
That's your opinion. :)
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C4DDA1F.622EAD6F>