Date: Sun, 11 May 2014 20:54:54 -0600 From: Warner Losh <imp@bsdimp.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: freebsd-current Current <freebsd-current@freebsd.org>, "jenkins-admin@freebsd.org" <jenkins-admin@freebsd.org> Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 Message-ID: <0066AA01-132B-4042-88FE-DE264667BF81@bsdimp.com> In-Reply-To: <CAG=rPVdjYfnwNuzG8GS8iFP7=wtvNorBZDqPZkOuwDiJseoj0Q@mail.gmail.com> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <CAG=rPVdHR29qMsvZVfVxBgoX4Jg7sXXWePZ9%2BvvyPOcLqL5R8A@mail.gmail.com> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <CAG=rPVd8JVLxV1pFUVWsZBX1OnFAEUU6MeBugO3JH7Yf0gSXnA@mail.gmail.com> <130417FC-CE39-43DE-B87F-DF2185FC94DC@bsdimp.com> <CAG=rPVeR3yWsYfu-USFbbVoZB4Fua1V6hBnMgZF=%2BtiXFMq_dw@mail.gmail.com> <9A75A814-1B7B-45DB-960D-346A23F9F99A@bsdimp.com> <CAG=rPVdjYfnwNuzG8GS8iFP7=wtvNorBZDqPZkOuwDiJseoj0Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On May 11, 2014, at 7:50 PM, Craig Rodrigues <rodrigc@FreeBSD.org> wrote: > On Sun, May 11, 2014 at 4:22 PM, Warner Losh <imp@bsdimp.com> wrote: >> >> >> The only logic that can work is to test MAKESYSPATH and respect it if it is defined, and use the relative path if not (since we don't require MAKESYSPATH to be defined to do a out-of-tree module build, and could be built on a system that isn't running the latest current). > > That is a legitimate patch. I've seen people make similar changes to > the kernel makefiles an mk rules, > specifically folks who import > FreeBSD kernel source into their tree, but have the mk rules in > a "non-standard" place. > Thanks for applying this change. Sure. Still not sure what I think about it, but it does work and I have bigger fish to fry... >> Using JIRA to force it is rather an annoying use of JIRA since it makes making JIRA happy hard to test and outside the normal work flow. > > > Please use the correct terminology to avoid confusion. > Jenkins is not the same as JIRA. Yes. Others have corrected me as well. Sorry for the confusion… Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTcDf+AAoJEGwc0Sh9sBEAmjEP/3CXY17LXmhqa/jf7m/OFmJa kBC0nQxMrvRyxlfSg048h3u1malIVVoboogZT86xEFwOWcPcHuV560WVHt34W5JB lKRvLUHV+Axygv/tVuleeynKeKk6APLxSuCnrmc/+ZA9JB+KzJBKiSduWsHCcuHY kNl24z5FMgPguJsz053c7Tl7Ul1m6gUN4hTVZTJl6AK+DePBu5F35yNB8GsWxZdt rcZG9uD18lS5dNKNJhCDNif2VHLiwVDbtODyiUX4OIAarvKEq4uq8SBT5yPbanjV mhwQeOEAAfC+KhmjY3125ujD/75Y53sjKXAdtdMYoLdW/UXL3rR8T0PkoB4/CfhV Wv4JTyHcq4eT2eyFjfmOY7DLFayjXa8GNhekmw9OmSRfosRcZKXmoKd5wP5/3biu h8dssTf2SVqWmpTws67Bn0LV/LlU3l+W2yJuEyjGHVerpLD1l1FR9ujGmEzX64HY SBJ/GixCEMUcgkBA0or3jzXq28PLzLn6QEnCH+AuVIZ84tSgoYCjCn6amOZTjvAF /IoqpecYyN7FHc3YyLUAaBeVPaw80ec0KtC+toWptip/HmUDVAP0Pa/GkSj4UwV8 GcauFLgJQ+11mgTmn6fwk21D1qvI5g+YcWFQA+j28MQIKrVCanhjT7DQzWSQLXnW gC6uV+SjoxOnLWQcYDoE =MNzl -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0066AA01-132B-4042-88FE-DE264667BF81>