Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 31 Dec 2015 13:29:12 -0500
From:      "Jonathan T. Looney" <jtl@freebsd.org>
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r292955 - head/lib/libmd
Message-ID:  <D2AADCD9.4E8C8%jlooney@juniper.net>
In-Reply-To: <20151231115651.R995@besplex.bde.org>
References:  <201512301804.tBUI4oGp065466@repo.freebsd.org> <20151231115651.R995@besplex.bde.org>

index | next in thread | previous in thread | raw e-mail

Dear Bruce,

On 12/30/15, 10:03 PM, "Bruce Evans" <brde@optusnet.com.au> wrote:

>On Wed, 30 Dec 2015, Jonathan T. Looney wrote:
>
>> Log:
>>  Fix a file descriptor leak in mdXhl.c (which is used by numerous
>>hashing
>>  algorithms.
>
>This code had amazingly low quality and is still especially broken near
>the main leak fixed.

Thanks for your attention to our code, and for pointing out these bugs. I
just volunteered to fix the "new" Coverity alert for a file descriptor
leak. (It was a "new" alert due to r292782, which reused this file for
SHA384.) However, I agree that there are still bugs in the code, and I'm
happy to work on those, too.

Happy New Year!

Jonathan




help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2AADCD9.4E8C8%jlooney>