Date: Thu, 4 May 2017 08:10:02 -0700 From: Conrad Meyer <cem@freebsd.org> To: Anish Gupta <anish@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r317600 - in head/sys: amd64/vmm/amd modules/vmm Message-ID: <CAG6CVpUK5Uqeh4vGZLe6eDfRfgyPiOwST%2B0C7eBPigWSG0NAOQ@mail.gmail.com> In-Reply-To: <CAG6CVpVa9z2T=D8oOqL%2B4U0PPmW-sJLg2Bs9FnA%2B%2BUrSrDzkKA@mail.gmail.com> References: <201704300208.v3U28lZo093446@repo.freebsd.org> <CAG6CVpVa9z2T=D8oOqL%2B4U0PPmW-sJLg2Bs9FnA%2B%2BUrSrDzkKA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 4, 2017 at 7:58 AM, Conrad Meyer <cem@freebsd.org> wrote: > On Sat, Apr 29, 2017 at 7:08 PM, Anish Gupta <anish@freebsd.org> wrote: >> Author: anish >> Date: Sun Apr 30 02:08:46 2017 >> New Revision: 317600 >> URL: https://svnweb.freebsd.org/changeset/base/317600 >> >> Log: >> Add AMD IOMMU/AMD-Vi support in bhyve for passthrough/direct assignment to VMs. To enable AMD-Vi, set hw.vmm.amdvi.enable=1. >> >> Reviewed by:bcr >> Approved by:grehan >> Tested by:rgrimes >> Differential Revision:https://reviews.freebsd.org/D10049 >> ... Hi Anish, One more Coverity warning that came in with this commit: In ivrs_drv.c: ivrs_hdr_iterate_tbl(), there is a check for 'ivrs_hdr->Length < 0'. However, Length has an unsigned type and cannot be negative, so the check can never be true. (CID: 1374746.) Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUK5Uqeh4vGZLe6eDfRfgyPiOwST%2B0C7eBPigWSG0NAOQ>