Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 May 2005 13:23:31 -0700
From:      Bakul Shah <bakul@BitBlocks.com>
To:        Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
Cc:        freebsd-current@freebsd.org
Subject:   Re: CURRENT: ifconfig tap0 results in core dump 
Message-ID:  <200505192023.j4JKNVLw038968@gate.bitblocks.com>
In-Reply-To: Your message of "Thu, 19 May 2005 12:25:55 PDT." <428CE843.7040705@savvis.net> 

next in thread | previous in thread | raw e-mail | index | archive | help
i don't know about the if_tap.c fix but the following at
fixes the segfault in ifconfig.c without any information loss
as far as i can tell.

Index: ifconfig.c
===================================================================
RCS file: /home/ncvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.112
diff -w -u -b -r1.112 ifconfig.c
--- ifconfig.c	8 Apr 2005 21:37:41 -0000	1.112
+++ ifconfig.c	19 May 2005 20:14:02 -0000
@@ -869,7 +869,7 @@
 		if (allfamilies) {
 			const struct afswtch *p;
 			p = af_getbyfamily(info.rti_info[RTAX_IFA]->sa_family);
-			if (p != NULL)
+			if (p != NULL && p->af_status != NULL)
 				p->af_status(s, &info);
 		} else if (afp->af_af == info.rti_info[RTAX_IFA]->sa_family)
 			afp->af_status(s, &info);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505192023.j4JKNVLw038968>