Date: Sun, 07 Sep 2014 15:28:33 -0700 From: Sean Bruno <sbruno@ignoranthack.me> To: Glen Barber <gjb@FreeBSD.org> Cc: freebsd-current@freebsd.org Subject: Re: NO INET6 warning Message-ID: <1410128913.10027.19.camel@bruno> In-Reply-To: <20140907210802.GA48287@hub.FreeBSD.org> References: <1410123815.10027.18.camel@bruno> <20140907210802.GA48287@hub.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2014-09-07 at 17:08 -0400, Glen Barber wrote:
> On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote:
> > make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" line
> > 12: warning: Couldn't read shell's output for
> > "cat /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys/WZR-300HP/opt_inet6.h"
> >
> >
> > Shouldn't this cat be done in a saner way?
> >
>
> This is done quite often throughout the tree, and bmake(1) does not like
> it when there is no value assigned from the '!=' expansion.
>
> The fix I've seen most commonly done is to echo a newline after the
> assignment, such as:
>
> Index: sys/modules/if_gif/Makefile
> ===================================================================
> --- sys/modules/if_gif/Makefile (revision 271215)
> +++ sys/modules/if_gif/Makefile (working copy)
> @@ -9,7 +9,7 @@ KMOD= if_gif
> SRCS= if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h
>
> .if defined(KERNBUILDDIR)
> -OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h
> +OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h; echo
> .if empty(OPT_INET6)
> MK_INET6_SUPPORT=no
> .endif
>
> Glen
>
LGTM
sean
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1410128913.10027.19.camel>