Date: Mon, 5 Dec 2011 17:00:35 GMT From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Message-ID: <201112051700.pB5H0ZJU011725@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163076; it has been noted by GNATS. From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: Petr Salinger <Petr.Salinger@seznam.cz>, bug-followup@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Mon, 05 Dec 2011 16:38:35 +0000 In message <20111205144947.GA2267@a91-153-116-96.elisa-laajakaista.fi>, Jaakko Heinonen writes: >Yes, r222004 changed sbuf_finish() to not clear s->s_error which causes >the regression. I am not sure if we should blame r222004 or the pseudofs >code. The sbuf code is correct. Sbufs were designed to have "latching error semantics" and any errors should not be cleared by sbuf_finish() for exactly that reason. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112051700.pB5H0ZJU011725>