Date: Thu, 1 Jun 2017 13:14:41 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Marcel Moolenaar <marcel@FreeBSD.org>, Brooks Davis <brooks@FreeBSD.org>, svn-src-all@FreeBSD.org, "Simon J. Gerraty" <sjg@juniper.net>, src-committers <src-committers@FreeBSD.org>, svn-src-head@FreeBSD.org, Ngie Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <8EE5D277-E03A-4B90-BDF0-9C0A521567FC@gmail.com> In-Reply-To: <20170601200605.GA66626@FreeBSD.org> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <84744.1496336318@kaos.jnpr.net> <20170601171642.GA601@FreeBSD.org> <EB38926C-C27C-4404-A1C4-69BC8525A00C@gmail.com> <20170601200605.GA66626@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jun 1, 2017, at 13:06, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote: >> ... >> I vote for not checking in the SHAs. If something fails (as someone else >> mentioned on the lists), it's really hard to debug why it failed. > > Like I've said, it's not "really" hard. Check out previous version and > generate image with correct hash, there is no strong reason to commit the > image other than minor usability improvement of not having to check out > previous version. > > Then again, just my $.02 -- I'm not the one doing actual work here. That’s assuming there aren’t endianness issues, and less intuitive issues (take the usr.sbin/sa tests for example — BLEH). With binary files like this, it’s best to do an abbreviated dump of sorts. Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZMHWxAAoJEPWDqSZpMIYVoQsQAKmil2mH2qrbtQB2/pF4WfIV 6Ep3021wEZYEI6i9ojmkmwhWeLUbBBxRmqgH01QnZBLSjqQl1Drhf8dGJ4IN8zBQ 1qXTmMk14M91r9qj3Ux339W/HsLCk1/LfbryGzTNWk8J8bfesFFwYBwtNKA7MZnd UTNwEIsbrkOEKbStERPVG9cXWDFS5Z0sz4Oq5mN4DooZ2XQtJ2TqvZ8p08R+gf/D 3NfAs8IgMD7ZWr41/jmd2Dmbw0kHJMSt+HybUOrQe2N1IrwEOugaEnmrJXaKtMBW 5HR9m638sn8J13prCPf/O+WAcOmdRmz+VwGpZnLXU1Bx9EUUdBQtP0Ipg8GJe/Px O+pR3kQE0VwVWlNPRWoUQXP6l7rUX2uAIGsL0dIGN4ZzcMdPo+cZclxBhA4H3LUc Hqo0m8CKQHN2RXHlH+68VbmDIYxo0weyZV5/S36Pqhlbb+AG0lRmKllOd/ndOcEP g2ZDAuH2oyDXaJSDB1R0HoFlnZtCP1Wy1SaaZgDyZjmk9pHwjGd2QzIjMfWkp0Da P5SleimxKpjV7TeKLc5Py3DnujraHqSZxJnzQCzBK4xgoCeDDLNyvQkRW/zmod9L PAhjCGU642VKFl3p0dr3NgnFX/QPUpd4aJP8Ft8d9Ndb3XDHBl41aah2QGDfyK/X wSuwHvtHVSQULtzzulO0 =B45j -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8EE5D277-E03A-4B90-BDF0-9C0A521567FC>