Date: Thu, 8 Mar 2012 14:49:49 -0800 From: Chuck Tuffli <chuck@tuffli.net> To: "Kenneth D. Merry" <ken@freebsd.org> Cc: freebsd-scsi <freebsd-scsi@freebsd.org> Subject: Re: CTL panic Message-ID: <CAM0tzX0UPvfUwnsrRBfFVkYQCccRtizaToD1Lk6-aB2rXPOL1A@mail.gmail.com> In-Reply-To: <20120308211455.GA85033@nargothrond.kdm.org> References: <CAM0tzX1TQK9E51DAQ2px=pPjEm%2B6JgbxrGDiE=LcxLyekNnvvw@mail.gmail.com> <20120308211455.GA85033@nargothrond.kdm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 8, 2012 at 1:14 PM, Kenneth D. Merry <ken@freebsd.org> wrote: > On Thu, Feb 23, 2012 at 13:44:10 -0800, Chuck Tuffli wrote: >> I just tried using our targ(9) compatible driver with CTL today and >> get the below panic. Our driver didn't recognize the >> XPT_IMMEDIATE_NOTIFY and returned CAM_REQ_INVALID which ctlfedone >> doesn't handle explicitly. The following patch seems to avoid this >> problem for me, but there might be a better fix. > > Sorry for the delayed response. No worries > Here is a patch that should fix it. =A0Although it isn't relevant for you > now, since your driver is talking to CTL successfully, it is still needed > for the mpt(4), ahc(4), ahd(4), and firewire drivers that support the old= er > target mode API. > > This hopefully fixes some of the issues inside CTL, and then essentially > prevents CTL from talking to target-capable SIMs that haven't been update= d > to support the CCBs that CTL needs. I tested this patch using our driver both - with PIT_PROCESSOR set and no XPT_IMMEDIATE_NOTIFY support - with PIT_PROC_CTL set and XPT_IMMEDIATE_NOTIFY support and both work as expected. So patch-wise, ACK / "works for me" ---chuck
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAM0tzX0UPvfUwnsrRBfFVkYQCccRtizaToD1Lk6-aB2rXPOL1A>