Date: Wed, 11 Jan 2017 22:54:58 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Sean Bruno <sbruno@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311931 - head/sys/dev/e1000 Message-ID: <821fe1c5-8173-1f2d-f691-2d89eb8b0e69@yandex.ru> In-Reply-To: <201701111929.v0BJTX4m030279@repo.freebsd.org> References: <201701111929.v0BJTX4m030279@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11.01.2017 22:29, Sean Bruno wrote: > Author: sbruno > Date: Wed Jan 11 19:29:33 2017 > New Revision: 311931 > URL: https://svnweb.freebsd.org/changeset/base/311931 > > Log: > Restore v6 offload caps for igb(4) class devices. > Modified: head/sys/dev/e1000/if_em.h > ============================================================================== > --- head/sys/dev/e1000/if_em.h Wed Jan 11 19:29:28 2017 (r311930) > +++ head/sys/dev/e1000/if_em.h Wed Jan 11 19:29:33 2017 (r311931) > @@ -330,7 +330,8 @@ > #define EM_MSIX_LINK 0x01000000 /* For 82574 use */ > #define ETH_ZLEN 60 > #define ETH_ADDR_LEN 6 > -#define CSUM_OFFLOAD 7 /* Offload bits in mbuf flag */ > +#define EM_CSUM_OFFLOAD 7 /* Offload bits in mbuf flag */ > +#define IGB_CSUM_OFFLOAD 0x0E0F /* Offload bits in mbuf flag */ Hi, Sean, why did you not define these masks using macros from sys/mbuf.h? It seems it would be more readable. -- WBR, Andrey V. Elsukov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?821fe1c5-8173-1f2d-f691-2d89eb8b0e69>