Date: Wed, 21 Dec 2011 12:42:50 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv Message-ID: <4EF244CA.8040108@FreeBSD.org> In-Reply-To: <CAF6rxgku88PABx9J8UxfLkKm%2BY-3b6%2BDB%2BX6cjUce-LfX7VESg@mail.gmail.com> References: <201112212027.pBLKRfPK084637@svn.freebsd.org> <4EF243F2.7030000@FreeBSD.org> <CAF6rxgku88PABx9J8UxfLkKm%2BY-3b6%2BDB%2BX6cjUce-LfX7VESg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/21/2011 12:40 PM, Eitan Adler wrote: > On Wed, Dec 21, 2011 at 3:39 PM, Doug Barton <dougb@freebsd.org> wrote: >> A better way to write this commit log would be, "Remove null pointer >> checks that are extraneous because ..." 2/3 why, 1/3 what. > > Noted. Thanks. However, I was perhaps too subtle in asking you to actually explain why they were not needed. :) >>> - Fix memory leak >> >> Should this perhaps have been a separate commit? > > Probably. I'll be more careful next time. Awesome! Doug -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EF244CA.8040108>