Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Sep 2011 12:51:35 GMT
From:      Henning Petersen <henning.petersen@t-online.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   misc/160867: Swapped arguments in cap_test_capmode.c
Message-ID:  <201109211251.p8LCpZBa003992@red.freebsd.org>
Resent-Message-ID: <201109211300.p8LD0Htb006525@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help


>Number:         160867
>Category:       misc
>Synopsis:       Swapped arguments in cap_test_capmode.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 21 13:00:17 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Henning Petersen
>Release:        
>Organization:
>Environment:
>Description:
Swapped arguments in cap_test_capmode.c .
>How-To-Repeat:

>Fix:
diff -u -r1.2 cap_test_capmode.c
--- tools/regression/security/cap_test/cap_test_capmode.c	4 Aug 2011 14:20:13 -0000	1.2
+++ tools/regression/security/cap_test/cap_test_capmode.c	21 Sep 2011 08:53:46 -0000
@@ -117,7 +117,7 @@
 	CHECK_SYSCALL_SUCCEEDS(close, fd_close);
 	CHECK_SYSCALL_SUCCEEDS(dup, fd_file);
 	CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb);
-	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0);
+	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET);
 	CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC);
 	CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0);
 	CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch));


Patch attached with submission follows:

diff -u -r1.2 cap_test_capmode.c
--- tools/regression/security/cap_test/cap_test_capmode.c	4 Aug 2011 14:20:13 -0000	1.2
+++ tools/regression/security/cap_test/cap_test_capmode.c	21 Sep 2011 08:53:46 -0000
@@ -117,7 +117,7 @@
 	CHECK_SYSCALL_SUCCEEDS(close, fd_close);
 	CHECK_SYSCALL_SUCCEEDS(dup, fd_file);
 	CHECK_SYSCALL_SUCCEEDS(fstat, fd_file, &sb);
-	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, SEEK_SET, 0);
+	CHECK_SYSCALL_SUCCEEDS(lseek, fd_file, 0, SEEK_SET);
 	CHECK_SYSCALL_SUCCEEDS(msync, &fd_file, 8192, MS_ASYNC);
 	CHECK_SYSCALL_SUCCEEDS(profil, NULL, 0, 0, 0);
 	CHECK_SYSCALL_SUCCEEDS(read, fd_file, &ch, sizeof(ch));


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109211251.p8LCpZBa003992>