Date: Fri, 22 Apr 2011 09:08:29 -0700 (PDT) From: David Wolfskill <david@catwhisker.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/156579: Tweak to Makefile.in to document which kernel is installed Message-ID: <201104221608.p3MG8T6k042830@albert.catwhisker.org> Resent-Message-ID: <201104221610.p3MGA9ON032202@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 156579
>Category: kern
>Synopsis: Tweak to Makefile.in to document which kernel is installed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Apr 22 16:10:09 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: David Wolfskill
>Release: FreeBSD 9.0-CURRENT i386
>Organization:
Wolfskill & Dowlng Residence
>Environment:
System: FreeBSD g1-222.catwhisker.org. 9.0-CURRENT FreeBSD 9.0-CURRENT #208 r220945: Fri Apr 22 05:26:37 PDT 2011 root@g1-220.catwhisker.org.:/usr/obj/usr/src/sys/CANARY i386
>Description:
Performing "make kernel" (or "make buildkernel installkernel")
causes various "progress messages" to be logged at certain
"milestone" events in the course of the build/install.
Some of them mention (for example) which kernel configuration
file is being used for the kernel build, e.g.:
>>> Kernel build for CANARY started on Fri Apr 22 05:16:35 PDT 2011
...
>>> Kernel build for CANARY completed on Fri Apr 22 05:38:52 PDT 2011
This is sometimes useful, and at worst, nearly harmless.
The corresponding message for the installation of the kernel,
however, merely reads:
>>> Installing kernel
While that's better than nothing, and it's actually quite
adequate for machines that build a single kernel image, for
machines that are used to build other kernels, or for their
"clients" -- machines that install kernels that they don't build
-- I believe it would be a bit more useful to augment the above
to read (e.g.):
>>> Installing kernel CANARY
(This could be augmented with a time stamp and/or the name of
the directory in /boot where it is being installed, but I see
those as not quite as important -- so I've restricted the scope
of this PR.)
>How-To-Repeat:
Build & install some kernels. Here are some excerpts from my
build machine:
>>> Kernel build for GENERIC started on Fri Apr 22 04:17:35 PDT 2011
>>> Kernel build for GENERIC completed on Fri Apr 22 04:19:46 PDT 2011
>>> Kernel build for ALBERT started on Fri Apr 22 04:19:46 PDT 2011
>>> Kernel build for ALBERT completed on Fri Apr 22 04:21:45 PDT 2011
>>> Kernel build for JANUS started on Fri Apr 22 04:21:45 PDT 2011
>>> Kernel build for JANUS completed on Fri Apr 22 04:23:40 PDT 2011
>>> Installing kernel
And here's a corresponding excerpt from one of its clients:
>>> Installing kernel
And from the other of its clients:
>>> Installing kernel
I think that augmenting the "Installing kernel" to mention
which kernel config was being installed on which machine might
be useful for other folks, not just me. :-}
>Fix:
For the request being made:
Index: Makefile.inc1
===================================================================
--- Makefile.inc1 (revision 220945)
+++ Makefile.inc1 (working copy)
@@ -868,7 +868,7 @@
false
.endif
@echo "--------------------------------------------------------------"
- @echo ">>> Installing kernel"
+ @echo ">>> Installing kernel ${KERNCONF}"
@echo "--------------------------------------------------------------"
cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
${CROSSENV} PATH=${TMPPATH} \
For a rather more elaborate approach
Index: Makefile.inc1
===================================================================
--- Makefile.inc1 (revision 220945)
+++ Makefile.inc1 (working copy)
@@ -868,7 +868,7 @@
false
.endif
@echo "--------------------------------------------------------------"
- @echo ">>> Installing kernel"
+ @echo ">>> Installing kernel ${KERNCONF} as ${INSTALLKERNEL} on `LC_ALL=C date`"
@echo "--------------------------------------------------------------"
cd ${KRNLOBJDIR}/${INSTALLKERNEL}; \
${CROSSENV} PATH=${TMPPATH} \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104221608.p3MG8T6k042830>