Date: Fri, 10 Feb 2006 19:53:02 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Conrad Sabatier <conrads@cox.net> Cc: freebsd-stable@freebsd.org Subject: Re: CFLAGS in libc_r, libpthread and libthr, and MUTEX stuff in kern_mutex.c Message-ID: <20060211005302.GA73491@xor.obsecurity.org> In-Reply-To: <XFMail.20060210170018.conrads@cox.net> References: <XFMail.20060210170018.conrads@cox.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Feb 10, 2006 at 05:00:18PM -0600, Conrad Sabatier wrote: > Given that STABLE is supposed to be...well...*stable* :-) ... > > Could we possibly remove "-D_PTHREADS_INVARIANTS", "-D_LOCK_DEBUG" and "-g" > from the CFLAGS in the Makefiles for libc_r, libpthread and libthr? I've > been under the impression that these options were only intended for > testing/debugging under CURRENT. I think your impressions are wrong. For example, -g has no effect on the installed code (since it's stripped), and IIRC -D_PTHREADS_INVARIANTS doesn't have a run-time penalty either. > On a related note, I was rather surprised to discover recently that in > sys/kern/kern_mutex.c, the MUTEX_WAKE_ALL option is forcibly defined if not > already defined in the user's kernel config. While the accompanying > comment (in mutex.c) would seem to indicate that there's good reason for > doing so at this time, at the very least, this should be documented in > sys/conf/NOTES as well. > > Additionally, it should also be made unmistakably clear that certain other > mutex-related options -- namely, ADAPTIVE_GIANT and NO_ADAPTIVE_MUTEXES -- > have absolutely no effect whatsoever unless SMP is also defined. While I > suppose this might be inferred from the fact that they're listed under the > SMP section of NOTES, nonetheless, there is a chance that this relationship > may go unrecognized. Sounds like you can submit a patch for these. Kris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD7TVuWry0BWjoQKURAiOPAKDhFIjvVISseTCRsmiFJyQ+lRKoJwCdHd21 KOJNOjLmzssrjxlsz5tJhuI= =O3pp -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060211005302.GA73491>