Date: Mon, 23 Jan 2006 00:39:06 +0100 From: "Wojciech A. Koszek" <dunstan@zsno.ids.czest.pl> To: freebsd-current@freebsd.org Cc: Richard Todd <rmtodd@ichotolot.servalan.com>, rwatson@freebsd.org Subject: Re: Bug in latest rev kern_acct.c: panic: Trying sleep, but thread marked as sleeping prohibited Message-ID: <20060122233906.GA87779@zsno.ids.czest.pl> In-Reply-To: <20060101182227.GB17837@FreeBSD.czest.pl> References: <20051221031526.31ABC290@mx2.synetsystems.com> <200512211111.44268.jhb@freebsd.org> <20051227173434.GA53513@FreeBSD.czest.pl> <x7hd8osrwc.fsf@ichotolot.servalan.com> <20060101182227.GB17837@FreeBSD.czest.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 01, 2006 at 06:22:27PM +0000, Wojciech A. Koszek wrote: > On Sat, Dec 31, 2005 at 06:39:31PM -0600, Richard Todd wrote: > > "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> writes: > > > > > On Wed, Dec 21, 2005 at 11:11:43AM -0500, John Baldwin wrote: > > >> acctwatch() probably isn't a good thing to do from a callout since it wants to > > >> do VOPs and such. Probably the easiest fix is to stick acctwatch() in its > > >> own kthread. > > > > > > I think I didn't break current behaviour. Patch is here: > > > > > > http://freebsd.czest.pl/dunstan/FreeBSD/kern_acct.0.patch > > > > > > Richard, could you try to repeat your problem with my patch? > > > > Got a chance to try a new kernel today with your patch. I tried to reproduce > > the panic by repeatedly copying a bunch of stuff onto /usr and deleting it > > in one window, and in another repeatedly doing "make configure; make clean" > > in one rather large port. Lots of "Accounting suspended/resumed" messages > > in the logs and no panics. So it's looking good from here. > > Thanks for testing this. I couldn't crash my box either. I belive that > KASSERT() before suspend/resume handling will always be true, just like > ACCT_ENABLED state. In the final version of the patch I'll include some > cosmetic changes suggested by Robert Watson (thanks!). (Sorry for late response. I'm having terrible problems with DNS server for freebsd.czest.pl. I'll try to get them fixed this week). Updated patch for accouting is here: http://zsno.ids.czest.pl/~dunstan/FreeBSD/kern_acct.2.patch -- * Wojciech A. Koszek && <dunstan%zsno.ids.czest.pl>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060122233906.GA87779>