Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Aug 2019 15:37:20 +0000 (UTC)
From:      Michal Meloun <mmel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r351189 - head/sys/dev/fdt
Message-ID:  <201908181537.x7IFbKbo048954@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mmel
Date: Sun Aug 18 15:37:19 2019
New Revision: 351189
URL: https://svnweb.freebsd.org/changeset/base/351189

Log:
  Fix bug introduced by r351184.
  We should check the returned handle, not the pointer to it.
  
  Noticed by:	ian
  X-MFC with:	r351184
  MFC after:	1 week

Modified:
  head/sys/dev/fdt/simple_mfd.c

Modified: head/sys/dev/fdt/simple_mfd.c
==============================================================================
--- head/sys/dev/fdt/simple_mfd.c	Sun Aug 18 11:43:58 2019	(r351188)
+++ head/sys/dev/fdt/simple_mfd.c	Sun Aug 18 15:37:19 2019	(r351189)
@@ -134,7 +134,7 @@ simple_mfd_syscon_get_handle(device_t dev, struct sysc
 
 	sc = device_get_softc(dev);
 	*syscon = sc->syscon;
-	if (syscon == NULL)
+	if (*syscon == NULL)
 		return (ENODEV);
 	return (0);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908181537.x7IFbKbo048954>