Date: Wed, 30 May 2018 07:27:03 -0700 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Peter Grehan <grehan@freebsd.org>, Justin Hibbits <jhibbits@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334365 - head/sys/dev/pci Message-ID: <264b6c9f-efa3-13e8-1d41-0cdc8631ec82@freebsd.org> In-Reply-To: <25bd4319-6d7f-e668-88e4-4c3adbc1e8e9@freebsd.org> References: <201805300241.w4U2fmvB033942@repo.freebsd.org> <25bd4319-6d7f-e668-88e4-4c3adbc1e8e9@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/30/18 02:42, Peter Grehan wrote: >> PCIe only permits 1 device on an endpoint, so some devices ignore >> the device >> part of B:D:F probing. Although ARI likely fixes this, not all >> platforms >> support ARI completely or correctly, so some devices end up >> showing up 32 >> times on the bus. > > I think this might have broken bhyve - a fake PCIe capability is put > on the root port so that guests will use MSI/MSI-x, but otherwise it > looks like parallel PCI. Not exactly spec-compliant, but then neither > is most of the world of PCI/PCIe. > > It may be worth #ifdef'ing this with powerpc. > > later, > > Peter. > There are a ton of ARM boards that need this too. You can find one-off hacks all through the tree and one of the nice things about this change is that all of those can be consolidated/removed now. If we are going to have some #ifdef and special cases, it would be better to make them for bhyve. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?264b6c9f-efa3-13e8-1d41-0cdc8631ec82>