Date: Mon, 18 Aug 2003 14:04:39 -0400 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: "Simon L. Nielsen" <simon@FreeBSD.org> Cc: freebsd-doc@FreeBSD.org Subject: Re: Review of porters-handbook changes Message-ID: <1061229879.730.54.camel@gyros> In-Reply-To: <20030818125337.GB407@FreeBSD.org> References: <1061069299.54862.34.camel@shumai.marcuscom.com> <20030817110722.GA391@FreeBSD.org> <1061131638.43833.2.camel@shumai.marcuscom.com> <20030818125337.GB407@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, 2003-08-18 at 08:53, Simon L. Nielsen wrote: > On 2003.08.17 10:47:18 -0400, Joe Marcus Clarke wrote: > > On Sun, 2003-08-17 at 07:07, Simon L. Nielsen wrote: > > > On 2003.08.16 17:28:19 -0400, Joe Marcus Clarke wrote: > > > > Can someone review the attached diff to the porter's handbook? It was > > > > submitted by Sergey Matveychuk <sem@ciam.ru> for some of the recent > > > > ports infrastructure changes. It is technically accurate, and I fixed a > > > > few grammar and spelling nits, but I would like a doc committers take on > > > > it before committing. Also, if one of you would rather commit, that's > > > > fine. Thanks! > > > > > > There are some places where 8 spaces have been used instead of a tab > > > (can be fixed by marking the regions and using 'meta-x tabify' in > > > emacs'). There are also some end of line white-spaces which should be > > > removed. > > > > I tried to preserve the style of adjacent blocks. To that end, some use > > spaces, so I opted for spaces to keep things lined up. > > OK, I didn't check the rest for the file for style, and the tab/space > thing is not that important then. > > But the end of line whitespace still doesn't need to be there :). It's > not crucial to remove it, but there is no reason to have it there. > > Sorry for being so pedantic about this... > > I have attached a patch where I have removed the end of line whitespace, > and changed the pkg_deinstall reference (see below). > > > --- doc/en_US.ISO8859-1/books/porters-handbook/book.sgml 17 Aug 2003 09:12:05 -0000 1.320 > > +++ doc/en_US.ISO8859-1/books/porters-handbook/book.sgml 17 Aug 2003 14:46:25 -0000 > > @@ -4316,6 +4086,19 @@ > > </note> > > </sect1> > > > > + <sect1 id="pkg-deinstall"> > > + <title><filename>pkg-deinstall</filename></title> > > + > > + <para>This script executes when a package is removed.</para> > > + > > + <para> > > + This script will be run twice by <command>pkg_delete</command>. > > It's better to use "&man.pkg.delete.1;" instead of the command tag since > it will create a link to the manual page. Thanks! Committed with your suggestions after doing a full make of doc/. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQA/QRU3b2iPiv4Uz4cRAnFYAJwJa1USCJwpzuJkoVl6bn7I2/31MwCglfHg kFs7S9QNzZwzq4rYIll+Xxw= =jG1k -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1061229879.730.54.camel>