Date: Sat, 5 Jul 2014 15:07:50 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: David Chisnall <theraven@theravensnest.org> Cc: Hans Petter Selasky <hps@selasky.org>, stable@freebsd.org, "current@freebsd.org" <current@freebsd.org> Subject: Re: [HEADS-UP] Problem with clang in 9-stable [was: r268244 (stable/9) seems to break "sysctl hw.ncpu"] Message-ID: <F7112AF8-82DD-410D-97A1-C01FFB49B3B4@FreeBSD.org> In-Reply-To: <909248A4-1B7C-4836-ADAA-F81A70A8AC3C@theravensnest.org> References: <20140704123901.GR6056@albert.catwhisker.org> <53B6E218.5070009@selasky.org> <20140704174705.GS6056@albert.catwhisker.org> <53B6EDD1.8030506@selasky.org> <20140704181831.GV6056@albert.catwhisker.org> <909248A4-1B7C-4836-ADAA-F81A70A8AC3C@theravensnest.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 05 Jul 2014, at 14:49, David Chisnall <theraven@theravensnest.org> wrote:
> On 4 Jul 2014, at 19:18, David Wolfskill <david@catwhisker.org> wrote:
>
>> clang -O2 -pipe -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -o sysctl sysctl.o
>
> This compile line is turning off a lot of warnings. In particular, -Wno-uninitialized and -Wno-parentheses-equality are likely to hide warnings that refer to real errors.
Interestingly, -Wno-uninitialized has been in bsd.sys.mk since r76861,
and the accompanying comment ("XXX Delete -Wuninitialized by default for
now -- the compiler doesn't always get it right") has never been
changed. :-)
It is probably time to re-enable that warning after 13 years, at least.
I'm not so sure about -Wno-parentheses-equality, because that might give
quite a few false positives, especially in old, contributed code.
-Dimitry
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.22 (Darwin)
iEYEARECAAYFAlO3+KYACgkQsF6jCi4glqOwnACbBHvEd5jjCn21OaTqw4Yt2xnb
kW4AmwVuMdRnWZaarzsr4FmKaT2RwSQ/
=T8v3
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F7112AF8-82DD-410D-97A1-C01FFB49B3B4>