Date: Tue, 20 Jun 2000 12:05:13 -0700 (PDT) From: Archie Cobbs <archie@whistle.com> To: julian@elischer.org (Julian Elischer) Cc: freebsd-net@FreeBSD.ORG Subject: Re: Patch review request (ng_ether(4)) Message-ID: <200006201905.MAA26374@bubba.whistle.com> In-Reply-To: <3938AA5E.15FB7483@elischer.org> from Julian Elischer at "Jun 2, 2000 11:49:02 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer writes: > > > > > As soon as I can access freefall again I'll put up a new patch. > > > > > > > > OK, try this one: > > > > > > > > ftp://ftp.whistle.com/pub/archie/misc/NGETHER.patch.2 > > > > > > you need to block attaches to orphan if the lower hook is in use, > > > and visa versa. > > > > It should already do that.. they both use priv->lower. > > OK > > comment in ng_ether_input_orphan() is wrong. > > You can't use NG_SEND_DATA_RET() in an ethernet driver (on input) > because you need to use NG_QUEUE_DATA() (splimp, remember) > My thought is that you would supply a separate hook for > 'FILTER' operations which you would warn would have to > be run at splimp. The splnet and splimp graphs can only be joined > by queueing links (going up). I think this needs work, and there > is a possibility that we could put transfer characteristics > as a property on links so that the right thing happens. OK, back from vacation :-) Here's a new patch addressing the above problem: ftp://ftp.whistle.com/pub/archie/misc/NGETHER.patch.3 > The FILTER hooks would either have to be attached > to nodes that use NG_QUEUE_DATA(), or which > had no connection to the splnet universe. Automatic registration > of spl levels on hooks might lead to some automatic handling > of this but > a/ I think the programmer should know what is going on. > b/ this may all become moot with the removal of SPLs for > interrupts. I vote for option (b) :-) -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006201905.MAA26374>