Date: Tue, 14 May 2002 21:19:32 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Peter Jeremy <peter.jeremy@alcatel.com.au> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, Peter Wemm <peter@FreeBSD.ORG> Subject: Re: cvs commit: src/sys/boot/i386/boot2 boot2.c Message-ID: <XFMail.20020514211932.jhb@FreeBSD.org> In-Reply-To: <20020515065310.A64295@gsmx07.alcatel.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14-May-2002 Peter Jeremy wrote: > On 2002-May-11 14:49:39 -0700, Peter Wemm <peter@FreeBSD.ORG> wrote: >> Save about 60 bytes by #define memcpy __builtin_memcpy and removing >> the function we provided. Restore the Keyboard: yes/no printf for the >> probe diagnostics. We end up with 40 bytes free. > > More potential savings: > - Change dev_nm definition to "const char dev_nm[4][] = ..." saves 7 bytes. > This amounts to saving 20 bytes of pointers, but the code bloats by > 13 bytes because of reversion from register-indirect to direct addressing > of dev_nm in several places. (Using [3] instead of [4] actually makes > things worse because *3 isn't possible in the R/I/M byte). > - Change dev_maj defn to "const unsigned char dev_maj[]" saves 15 bytes. These and other changes suggested sound good to me. No objections from me if you commit them. > Peter -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020514211932.jhb>