Date: Wed, 31 Jul 2013 11:33:51 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: obrien@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng Message-ID: <86zjt3f4zk.fsf@nine.des.no> In-Reply-To: <20130730185034.GA63635@dragon.NUXI.org> (David O'Brien's message of "Tue, 30 Jul 2013 11:50:34 -0700") References: <201307292058.r6TKwA56031193@svn.freebsd.org> <86fvuwgrs6.fsf@nine.des.no> <20130730185034.GA63635@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
"David O'Brien" <obrien@FreeBSD.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > We've had a policy for several years now that all changes to the > > PRNG code in the kernel and libc must be reviewed by so@. > Where was this policy published or communicated? > There is no MAINTAINER line in sys/dev/random/, nor an entry in > /usr/src/MAINTAINERS. It is hard to follow some policy that cannot > be found. If it isn't adequately documented, then we need to look into that. It's not the only such case - jfv@'s hard lock on Intel NIC drivers isn't documented either. That doesn't mean we shouldn't enforce it. > This change does not change any of the PRNG algorithms. You know as well as I do that "I didn't change anything" is in the top five on the list of "programmers' famous last words". > Do you have any specific concerns? I don't have any major issues with the patch, but it should still have been submitted for pre-commit review. I have two minor issues: - The sysctl is currently a space-separated list with an extraneous leading space and a magic string (which contains separators) to indicate an empty list. At the very least, the leading space should be removed and the magic string should be changed to not include spaces; "none" should suffice. I would prefer a comma-separated list and an empty string to indicate an empty list. - The non-standard (at least in an IT context) spelling of "adapter". I'll try to get a second opinion within the day. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zjt3f4zk.fsf>