Date: Sun, 30 Aug 2020 21:33:31 -0400 From: Ed Maste <emaste@freebsd.org> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r364321 - head/sbin/ipfw Message-ID: <CAPyFy2C1F9J5o38RcZHm%2BtD7gXQKxugaPhOfyjOoKem2tKXY=Q@mail.gmail.com> In-Reply-To: <202008172023.07HKNh1q061925@gndrsh.dnsmgr.net> References: <202008171853.07HIrNAC082123@repo.freebsd.org> <202008172023.07HKNh1q061925@gndrsh.dnsmgr.net>
index | next in thread | previous in thread | raw e-mail
Hrm, it seems this reply ended up in my spam folder; sorry for not
replying until now.
> > *strchr(timestr, '\n') = '\0';
> > bprintf(bp, "%s ", timestr);
> ^ Isnt this the +1 space?
>
> > } else {
> > - bprintf(bp, "%*s", twidth, " ");
> > + bprintf(bp, "%*s", twidth + 1, " ");
> ^missing from this string?
Inserting an extra space in the format string would also work, sure. I
considered doing it that way but in the end decided it's not
materially more clear one way or another, so used the patch as
submitted.
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2C1F9J5o38RcZHm%2BtD7gXQKxugaPhOfyjOoKem2tKXY=Q>