Date: Mon, 28 Jan 2013 22:40:05 GMT From: Yuri <yuri@tsoft.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/175661: [PATCH] Fix in libdtrace/Makefile of the dependency on dt_grammar.h Message-ID: <201301282240.r0SMe5bh064450@red.freebsd.org> Resent-Message-ID: <201301282250.r0SMo0bt064698@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 175661
>Category: misc
>Synopsis: [PATCH] Fix in libdtrace/Makefile of the dependency on dt_grammar.h
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jan 28 22:50:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Yuri
>Release: 9.1-STABLE
>Organization:
n/a
>Environment:
>Description:
Currently standalone build of libdtrace (cd /usr/src/cddl/lib/libdtrace && make clean && make) fails because dt_grammar.h is missing. It is consumed by few modules, like dt_cc.c, listed before dt_grammar.y that is producing it.
I am not sure why overall build doesn't fail for this reason, but if someone just needs to rebuild libdtrace.so he will see this failure.
This patch adds missing dependencies into the Makefile.
The weaker patch fixing the same problem would have been just moving dt_grammar.y into the first position in list in Makefile. But make will still have wrong dependency list and it will likely break on parallel build (-j 8).
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: cddl/lib/libdtrace/Makefile
===================================================================
--- cddl/lib/libdtrace/Makefile (revision 246040)
+++ cddl/lib/libdtrace/Makefile (working copy)
@@ -86,6 +86,13 @@
CLEANFILES= dt_errtags.c dt_names.c
+dt_grammar.h: dt_grammar.y
+dt_lex.o: dt_grammar.h
+dt_xlator.o: dt_grammar.h
+dt_cc.o: dt_grammar.h
+dt_cg.o: dt_grammar.h
+dt_parser.o: dt_grammar.h
+
dt_errtags.c:
sh ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/mkerrtags.sh < ${OPENSOLARIS_USR_DISTDIR}/lib/libdtrace/common/dt_errtags.h > dt_errtags.c
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301282240.r0SMe5bh064450>