Date: Wed, 10 Sep 2025 15:23:18 -0600 From: Warner Losh <imp@bsdimp.com> To: Phil Shafer <phil@juniper.net> Cc: Konstantin Belousov <kostikbel@gmail.com>, Ka Ho Ng <khng@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 11ace56fa030 - main - contrib/libxo: fix API header files inclusions in C++ source files Message-ID: <CANCZdfoZEcXgHHrkhEq0Uy7ztio-Dv=TKnNU4X4JQ590mZfnsA@mail.gmail.com> In-Reply-To: <CCBD49BA-56A2-4E6F-A33E-2A2D7A945335@juniper.net> References: <202509071842.587IgHbm001636@gitrepo.freebsd.org> <aMD_IRCC1wA7DpMI@kib.kiev.ua> <CCBD49BA-56A2-4E6F-A33E-2A2D7A945335@juniper.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000255110063e79082c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 10, 2025 at 1:49=E2=80=AFPM Phil Shafer <phil@juniper.net> wrot= e: > It's not freebsd-specific, but __BEGIN_DECLS isn't freebsd only. If it's > reasonably portable, it makes sense to use it. I see it in macOS, glibc, > and linux (at least some of dists). > I believe that it came from 4.4BSD and spread from there. Warner > Thanks, > Phil > > > > > On 10 Sep 2025, at 0:31, Konstantin Belousov wrote: > > > Would it be better to use __BEGIN_DECLS? I am not completely sure due t= o > > > > contrib/, but libxo is FreeBSD-specific enough already. > --000000000000255110063e79082c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g= mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Sep 10,= 2025 at 1:49=E2=80=AFPM Phil Shafer <<a href=3D"mailto:phil@juniper.net= ">phil@juniper.net</a>> wrote:<br></div><blockquote class=3D"gmail_quote= " style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);= padding-left:1ex">It's not freebsd-specific, but __BEGIN_DECLS isn'= t freebsd only.=C2=A0 If it's reasonably portable, it makes sense to us= e it.=C2=A0 I see it in macOS, glibc, and linux (at least some of dists).<b= r></blockquote><div><br></div><div>I believe that it came from 4.4BSD and s= pread=C2=A0from there.</div><div><br></div><div>Warner</div><div>=C2=A0</di= v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde= r-left:1px solid rgb(204,204,204);padding-left:1ex"> Thanks,<br> =C2=A0Phil<br> <br> <br> <br> <br> On 10 Sep 2025, at 0:31, Konstantin Belousov wrote:<br> <br> > Would it be better to use __BEGIN_DECLS? I am not completely sure due = to<br> ><br> > contrib/, but libxo is FreeBSD-specific enough already.<br> </blockquote></div></div> --000000000000255110063e79082c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoZEcXgHHrkhEq0Uy7ztio-Dv=TKnNU4X4JQ590mZfnsA>