Date: Fri, 1 Feb 2019 09:05:37 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Marcelo Araujo <araujo@freebsd.org>, Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343634 - head/usr.sbin/bhyve Message-ID: <CAOfEmZgrt1EzddzooFmdZgV1xyVqwVD1ngNK%2B%2BahwNfRiOV_sw@mail.gmail.com> In-Reply-To: <20190201010117.GA24863@kib.kiev.ua> References: <201901312332.x0VNWJ6o016057@repo.freebsd.org> <20190131234609.GZ24863@kib.kiev.ua> <CANCZdfoL=n2Bo-waSfNth2Q-ZN8Ej%2BvZ6_no7QWSRnNfQnAqxA@mail.gmail.com> <CAOfEmZhi%2Bj5D0KvSSE0HjwNZGiko5eGLtviFRdbBrk31g-GB%2Bw@mail.gmail.com> <20190201010117.GA24863@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Em sex, 1 de fev de 2019 =C3=A0s 09:01, Konstantin Belousov <kostikbel@gmai= l.com> escreveu: > On Fri, Feb 01, 2019 at 08:40:11AM +0800, Marcelo Araujo wrote: > > Em sex, 1 de fev de 2019 =C3=A0s 08:36, Warner Losh <imp@bsdimp.com> > escreveu: > > > > > > > > > > > On Thu, Jan 31, 2019, 4:46 PM Konstantin Belousov <kostikbel@gmail.co= m > > > wrote: > > > > > >> On Thu, Jan 31, 2019 at 11:32:19PM +0000, Marcelo Araujo wrote: > > >> > Author: araujo > > >> > Date: Thu Jan 31 23:32:19 2019 > > >> > New Revision: 343634 > > >> > URL: https://svnweb.freebsd.org/changeset/base/343634 > > >> > > > >> > Log: > > >> > Mostly a cosmetic change to replace strlen with strnlen. > > >> This is not cosmetic, and more, for instance the usage() part of the > > >> change > > >> does not make any sense to me. > > >> > > > > > > I specifically objected as well and was blown off. What gives? > > > > > > > I have asked you feedback and got none! I will revert the usage() chang= es > > later then. > > I noted the usage() chunk because it is the first one in the commit and > I stopped after I see the obvious issues with it, not because it is the > only wrong part. > Are you implying that all the patch is wrong? I have no problem to revert it at all if you give me the right reason, it was basically a port from another project that also uses bhyve. Best, --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org <http://www.freebsd.org/>; \/ \ ^ Power To Server. .\. /_)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZgrt1EzddzooFmdZgV1xyVqwVD1ngNK%2B%2BahwNfRiOV_sw>