Date: Thu, 4 Dec 2008 20:36:03 GMT From: Ed Schouten <ed@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 154071 for review Message-ID: <200812042036.mB4Ka328024550@repoman.freebsd.org>
index | next in thread | raw e-mail
http://perforce.freebsd.org/chv.cgi?CH=154071 Change 154071 by ed@ed_flippo on 2008/12/04 20:35:20 Hummm... It seems the problem is a little more complex. We should not need to call mark_for_update() (reading the source code), but for some reason this causes the input not to be drawn. If we call mark_for_update(scp, cursor + 1), we get a spontaneous reboot later on, because scp->end is out of bounds then. Temporary hack: call mark_for_update(scp, cursor + 1) unless we're at the last cell on the display. Affected files ... .. //depot/projects/mpsafetty/sys/dev/syscons/scterm-teken.c#7 edit Differences ... ==== //depot/projects/mpsafetty/sys/dev/syscons/scterm-teken.c#7 (text+ko) ==== @@ -273,7 +273,8 @@ p = sc_vtb_pointer(&scp->vtb, cursor); sc_vtb_putchar(&scp->vtb, p, map[ch], scteken_attr(a)); mark_for_update(scp, cursor); - mark_for_update(scp, cursor + 1); + /* XXX: why? */ + mark_for_update(scp, imin(cursor + 1, scp->xsize * scp->ysize - 1)); } static voidhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812042036.mB4Ka328024550>