Date: Sun, 16 May 2021 00:30:54 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Lutz Donnerhacke <lutz@donnerhacke.de> Cc: Lutz Donnerhacke <donner@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: <YKA9jrWPkeCUgwPf@kib.kiev.ua> In-Reply-To: <20210515205133.GA19770@belenus.iks-jena.de> References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <YKAkAcYHXN7XMyoL@kib.kiev.ua> <20210515195812.GB17734@belenus.iks-jena.de> <YKArpyRTTAah4LSG@kib.kiev.ua> <20210515205133.GA19770@belenus.iks-jena.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 15, 2021 at 10:51:33PM +0200, Lutz Donnerhacke wrote:
> On Sat, May 15, 2021 at 11:14:31PM +0300, Konstantin Belousov wrote:
> > On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> > > Of course it was a style commit.
> > >
> > > + /*
> > > + De-alias incoming echo and timestamp replies.
> > > + Alias incoming echo and timestamp requests.
> > > + */
> > > static int
> > > IcmpAliasIn1(struct libalias *la, struct ip *pip)
> > > {
> > > -
> > > LIBALIAS_LOCK_ASSERT(la);
> > > - /*
> > > - De-alias incoming echo and timestamp replies.
> > > - Alias incoming echo and timestamp requests.
> > > - */
> > > struct alias_link *lnk;
> >
> > I do not understand what are you trying to say.
>
> The diff above is a reformatting of the original diff in the commit.
> It does show, what really happend during the edit:
> - The empty line at the beginnen of the function body was removed
This is optional, empty line at the beginning for the functions without
local declarations was required before, and is allowed right now.
> - The comment at the beginning of the function body was moved
> before the function definition.
>
> The LIBALIAS_LOCK_ASSERT and the variable declarations were not moved.
So you changed some style, but left the large violation in place.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YKA9jrWPkeCUgwPf>