Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Sep 2023 21:51:16 GMT
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 210dd7aa1f48 - stable/14 - vfs: fix stale comment about freevnodes management
Message-ID:  <202309222151.38MLpG0q039307@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=210dd7aa1f48848707b09a172a957f0f4b7aacab

commit 210dd7aa1f48848707b09a172a957f0f4b7aacab
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2023-09-14 17:28:32 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2023-09-22 21:50:47 +0000

    vfs: fix stale comment about freevnodes management
    
    (cherry picked from commit 9dc0c983b0931f359c2ff10d47ad835ef74e929a)
---
 sys/kern/vfs_subr.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c
index 4c9cb6200f10..ed478d33aed0 100644
--- a/sys/kern/vfs_subr.c
+++ b/sys/kern/vfs_subr.c
@@ -1444,12 +1444,12 @@ static struct proc *vnlruproc;
 static int vnlruproc_sig;
 
 /*
- * The main freevnodes counter is only updated when threads requeue their vnode
- * batches. CPUs are conditionally walked to compute a more accurate total.
+ * The main freevnodes counter is only updated when a counter local to CPU
+ * diverges from 0 by more than VNLRU_FREEVNODES_SLOP. CPUs are conditionally
+ * walked to compute a more accurate total.
  *
- * Limit how much of a slop are we willing to tolerate. Note: the actual value
- * at any given moment can still exceed slop, but it should not be by significant
- * margin in practice.
+ * Note: the actual value at any given moment can still exceed slop, but it
+ * should not be by significant margin in practice.
  */
 #define VNLRU_FREEVNODES_SLOP 126
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202309222151.38MLpG0q039307>