Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Aug 2005 12:25:14 -0700
From:      Brooks Davis <brooks@one-eyed-alien.net>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson <rwatson@FreeBSD.org>, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/net if_var.h
Message-ID:  <20050802192514.GB19107@odin.ac.hmc.edu>
In-Reply-To: <200508021416.33768.jhb@FreeBSD.org>
References:  <200508021743.j72HhZRj009221@repoman.freebsd.org> <200508021416.33768.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--s2ZSL+KKDSLx8OML
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 02, 2005 at 02:16:32PM -0400, John Baldwin wrote:
> On Tuesday 02 August 2005 01:43 pm, Robert Watson wrote:
> > rwatson     2005-08-02 17:43:35 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/net              if_var.h
> >   Log:
> >   Add if_addr_mtx to struct ifnet, a mutex to protect ifnet-related add=
ress
> >   lists.  Add accessor macros.
> >
> >   This changes the size of struct ifnet, but ideally, all ifnet consume=
rs
> >   are now using if_alloc() to allocate these structures rather than
> >   embedding them into device driver softc's, so this won't modify the
> >   network device driver ABI.
> >
> >   MFC after:      1 week
>=20
> It still modifies the ABI because of all the code that does 'ifp->if_foo'=
=20
> unless you've added it to the end.

He did.  I should add some comments about this though.

FWIW, any consumers not using if_alloc() are jumping through some major
hoops to avoid a panic on if_attach() and asking for it.

-- Brooks

--=20
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4

--s2ZSL+KKDSLx8OML
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQFC78iZXY6L6fI4GtQRAlaVAKDWZ9tgCtOW0wChXhzjxNsiprkLxACgmYNp
AAGtVqXwCcBMDaHPLDcnD8Q=
=Gs54
-----END PGP SIGNATURE-----

--s2ZSL+KKDSLx8OML--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050802192514.GB19107>