Date: Mon, 11 Apr 2022 20:58:39 +0000 From: bugzilla-noreply@freebsd.org To: pkgbase@FreeBSD.org Subject: [Bug 254797] pkgbase: -dev packages with names containing '_' have incorrect dependencies. Message-ID: <bug-254797-36141-TuPaEfZ6Eo@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-254797-36141@https.bugs.freebsd.org/bugzilla/> References: <bug-254797-36141@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254797 Ed Maste <emaste@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #1 from Ed Maste <emaste@freebsd.org> --- Just discovered this commit: commit 09d83a060f37ba17b29c0e90f3a0e9aa9c735592 Author: Mark Johnston <markj@FreeBSD.org> Date: Mon Apr 26 15:15:31 2021 -0400 pkgbase: Remove package name mangling in generate-ucl.sh The mangling was present in the initial revision of the script, but its purpose is not clear. It may have been to avoid defining make(1) variables with a dash in the name, but this is permitted. Furthermore, it results in invalid dependency information if a dependency's name contains an underscore, causing e.g., libcompiler_rt-dev to depend on libcompiler-rt, and resulting in warnings when installing base system packages. Remove the mangling. Reviewed by: manu MFC after: 2 months Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D29883 release/packages/generate-ucl.sh | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-254797-36141-TuPaEfZ6Eo>