Date: Thu, 24 Nov 2016 17:27:17 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Marcelo Araujo <araujobsdport@gmail.com> Cc: araujo@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil Message-ID: <861sy0n8re.fsf@desk.des.no> In-Reply-To: <CAOfEmZgexP65RKz1=WxcFBWTYGYbnSHWMzknkGAeFN=DwjBL8A@mail.gmail.com> (Marcelo Araujo's message of "Thu, 24 Nov 2016 23:27:52 %2B0800") References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <CAOfEmZgexP65RKz1=WxcFBWTYGYbnSHWMzknkGAeFN=DwjBL8A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcelo Araujo <araujobsdport@gmail.com> writes: > We have code review, we have some many ways for communication, even > revert a commit if needed. No. This is the kind of mistake where the code will seem to work just fine and end up in a release before a user suddenly discovers that they have two instances of the same daemon running and trashing their data. If I remember correctly, the last time someone touched flopen(), everything worked except 'service mountd reload' stopped working. > Everybody can read the svn history. Yeah, but they don't. And before you say MAINTAINERS, they don't read or respect that either. Believe me, I have years of experience cleaning up after unapproved, unreviewed commits to code I maintain. Conversely, another committer once reverted a commit they had reviewed and approved because they thought I hadn't committed it and hit 'y' blindly when patch told them it was already applied. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?861sy0n8re.fsf>