Date: Mon, 16 Jul 2001 09:51:37 +0100 From: David Malone <dwmalone@maths.tcd.ie> To: Mike Barcroft <mike@q9media.com> Cc: audit@FreeBSD.org Subject: Re: inetd(8) warns patch Message-ID: <200107160951.aa79104@salmon.maths.tcd.ie> In-Reply-To: Your message of "Mon, 16 Jul 2001 01:08:17 EDT." <200107160508.f6G58HF31122@coffee.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> I would appreciate your comments on the patch at the end of this > message. I'm not entirely sure about removing the legacy setproctitle > stuff. If you'd like to keep it in there, the prototype for main() > will need two versions. One for the legacy setproctitle and one > for normal use. Looks fine to me, as long as __unused is considered acceptable in our code. (I know you can get rid of the __unused for compilers that don't understand it by using a #define, but if another compiler denotes unused variables/parameters by "unused int blah;" then you can't generate this statement.) Would you like me to commit it? (I'm also slightly suprised that the WARNS flags don't whine about the nasty SWAP marco which contains a gccism.) BTW - I was looking at doing WARNS stuff for syslogd and it doesn't seem to be very easy 'cos syslogd uses writev(2) and iov_base pointers are of type "char *" not "const char *". I'm not subscribed to -audit so I don't know if anyone has a suggested workaround for these situations. David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200107160951.aa79104>