Date: Mon, 31 Jul 2023 08:46:25 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 79e5fba255ef - main - cad/PrusaSlicer: update to 2.6.0 Message-ID: <CAGwOe2YvYmxnCMO6oJ2=3Vnc57hd8-RGO_sd1oGrR7XgfgXHJQ@mail.gmail.com> In-Reply-To: <ZMSg5A-a77EDobnZ@FreeBSD.org> References: <202307281248.36SCmERV027986@gitrepo.freebsd.org> <ZMO8UT68PlITqFuB@FreeBSD.org> <CAGwOe2YcXfogxwCODdHvOLPZExeXC_BN4knB3obFb_7EQUuA-g@mail.gmail.com> <ZMSg5A-a77EDobnZ@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, Jul 29, 2023 at 7:17 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote: > > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??: > > > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote: > > > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19 > > > > > > > > cad/PrusaSlicer: update to 2.6.0 > > > > > > > > PR: 272730 > > > > Reported by: michal.zielonka.8001@gmail.com > > > > Approved by: teodorsigaev@gmail.com (maintainer) > > > > --- > > > > cad/PrusaSlicer/Makefile | 14 +- > > > > cad/PrusaSlicer/distinfo | 6 +- > > > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +- > > > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +- > > > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 + > > > > .../files/patch-src_libnanosvg_nanosvg.h | 3109 > > > ++++++++++++++++++++ > > > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++ > > > > > > Who reviewed this? First, we don't create files via patches, and > > > > Maintainer did. It's in the commit log and in the PR. > > Which means they don't have a clue, and you as committer should have > requested this whole mess reworked, not checked in as is. These are > the basics your mentor should have explained, did he not? > You can contact them and ask them. I assume you know how to get that information. About how to contribute to FreeBSD, well, I **don't do** patch review/build testing in all supported platforms I can get my hands on/run testing in clean environments/modernization of old ports/train submitters/etc. But I *keep my fingers crossed when I do git push*. That has to count for something right? Have a nice day. > > ./danfe > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Jul 29, 2023 at 7:17 AM Alexey Dokuchaev <<a href="mailto:danfe@freebsd.org">danfe@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Jul 28, 2023 at 04:40:11PM +0200, Fernando Apestegu??a wrote:<br> > El vie, 28 jul 2023, 15:02, Alexey Dokuchaev escribi??:<br> > > On Fri, Jul 28, 2023 at 12:48:14PM +0000, Fernando Apestegu??a wrote:<br> > > > commit 79e5fba255ef2620dd872e21bdd7dc667fea3c19<br> > > ><br> > > > cad/PrusaSlicer: update to 2.6.0<br> > > ><br> > > > PR: 272730<br> > > > Reported by: <a href="mailto:michal.zielonka.8001@gmail.com" target="_blank">michal.zielonka.8001@gmail.com</a><br> > > > Approved by: <a href="mailto:teodorsigaev@gmail.com" target="_blank">teodorsigaev@gmail.com</a> (maintainer)<br> > > > ---<br> > > > cad/PrusaSlicer/Makefile | 14 +-<br> > > > cad/PrusaSlicer/distinfo | 6 +-<br> > > > cad/PrusaSlicer/files/patch-CMakeLists.txt | 19 +-<br> > > > cad/PrusaSlicer/files/patch-src_CMakeLists.txt | 15 +-<br> > > > cad/PrusaSlicer/files/patch-src_avrdude_arduino.c | 10 +<br> > > > .../files/patch-src_libnanosvg_nanosvg.h | 3109<br> > > ++++++++++++++++++++<br> > > > .../files/patch-src_libnanosvg_nanosvgrast.h | 1485 ++++++++++<br> > ><br> > > Who reviewed this? First, we don't create files via patches, and<br> > <br> > Maintainer did. It's in the commit log and in the PR.<br> <br> Which means they don't have a clue, and you as committer should have<br> requested this whole mess reworked, not checked in as is. These are <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> the basics your mentor should have explained, did he not?<br></blockquote></div><div class="gmail_quote"><br></div><div class="gmail_quote">You can contact them and ask them. I assume you know how to get that information.</div><div class="gmail_quote"><br></div><div class="gmail_quote">About how to contribute to FreeBSD, well, I **don't do** patch review/build testing in all supported platforms I can get my hands on/run testing in clean environments/modernization of old ports/train submitters/etc.</div><div class="gmail_quote">But I *keep my fingers crossed when I do git push*. That has to count for something right?</div><div class="gmail_quote"><br></div><div class="gmail_quote">Have a nice day.<br></div><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> ./danfe<br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2YvYmxnCMO6oJ2=3Vnc57hd8-RGO_sd1oGrR7XgfgXHJQ>