Date: Tue, 19 Nov 2002 22:16:28 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Nate Lawson <nate@root.org> Cc: Kris Kennaway <kris@obsecurity.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_cd.h src/sys/dev/ata atapi-cd.c src/sys/sys cdrio.h src/usr.sbin/burncd burncd.8 burncd.c src/usr.sbin/cdcontrol cdcontrol.1 cdcontrol.c Message-ID: <20021120061628.GA9011@rot13.obsecurity.org> In-Reply-To: <Pine.BSF.4.21.0211192108150.62331-100000@root.org> References: <20021120022910.GA7969@rot13.obsecurity.org> <Pine.BSF.4.21.0211192108150.62331-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2002 at 09:44:16PM -0800, Nate Lawson wrote: > I will commit a one-line addition that if the value is less than 177, > scale it appropriately. This change won't hurt the new API and > maintaining ABI is nice. Sounds like a good solution. > However, I'm a little dismayed at the review process here. The change has > been in -current for a month with a message saying it would be MFCd in a > month. Not one of the negative comments on the MFC has indicated a single > application outside of our tree that uses our _FreeBSD_only_ ioctl API. = =20 > Neither of the two maintainers who reviewed the patch had a problem with > it. Why didn't you express your concerns earlier? I didn't see the commit..sorry, but shit happens. Kris --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE92yi7Wry0BWjoQKURAir4AJkBaGI7vprVzQm6OtuApkaelkAyVgCeKfJV AnHF6qE5smLQxDuiKEpZsxI= =dl8/ -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021120061628.GA9011>