Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Jan 2021 22:12:29 +0000
From:      Alexander Richardson <arichardson@freebsd.org>
To:        Jessica Clarke <jrtc27@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>,  "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: c1a3d7f20696 - main - Remove remaining uses of ${COMPILER_FEATURES:Mc++11}
Message-ID:  <CA%2BZ_v8rs3f9fmR7zYDE-%2BEE5-F9TY=a5Jpne4b8-kMaFr5rceA@mail.gmail.com>
In-Reply-To: <71483E38-0C2A-4A03-99A7-1438A691A975@freebsd.org>
References:  <202101192138.10JLcj1E078724@gitrepo.freebsd.org> <71483E38-0C2A-4A03-99A7-1438A691A975@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 19 Jan 2021 at 21:42, Jessica Clarke <jrtc27@freebsd.org> wrote:
>
> On 19 Jan 2021, at 21:38, Alex Richardson <arichardson@FreeBSD.org> wrote:
> > diff --git a/usr.sbin/Makefile b/usr.sbin/Makefile
> > index bd2f0cbe0797..2e01b0fcf847 100644
> > --- a/usr.sbin/Makefile
> > +++ b/usr.sbin/Makefile
> > @@ -186,9 +186,7 @@ SUBDIR.${MK_NTP}+=        ntp
> > SUBDIR.${MK_OPENSSL}+=        keyserv
> > SUBDIR.${MK_PF}+=     ftp-proxy
> > SUBDIR.${MK_PKGBOOTSTRAP}+=   pkg
> > -.if ${COMPILER_FEATURES:Mc++11}
> > -SUBDIR.${MK_PMC}+=   pmc
> > -.endif
> > +SUBDIR.${MK_PMC}.${MK_CXX}+= pmc
>
> src.opts.mk already disables MK_PMC is MK_CXX is no.
>
> Jess.
>
Ah I didn't check src.opts. Will revert this part of the commit shortly.

Thanks,
Alex



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BZ_v8rs3f9fmR7zYDE-%2BEE5-F9TY=a5Jpne4b8-kMaFr5rceA>